[DowngradePhp81] Add AddReturnTypeWillChangeAttributeRector#372
Merged
TomasVotruba merged 1 commit intoMay 30, 2026
Merged
Conversation
- PHP 8.1 added provisional return types to built-in interfaces (ArrayAccess, Countable, Iterator, IteratorAggregate, Stringable), triggering deprecation notices on implementations without matching return types. - This rule automatically adds #[\ReturnTypeWillChange] to affected methods, suppressing those notices for codebases that need to remain compatible with older PHP versions and cannot yet add the required return types. Fixes: rectorphp/rector#9515
Member
|
Hi @jquiaios , thanks for the fix 👍 Let's ship it and see how it performs on Rector codebase downgrade |
samsonasik
reviewed
May 30, 2026
| { | ||
| foreach ($classMethod->attrGroups as $attrGroup) { | ||
| foreach ($attrGroup->attrs as $attr) { | ||
| if ($attr->name->getLast() === self::RETURN_TYPE_WILL_CHANGE) { |
Member
There was a problem hiding this comment.
getLast() is invalid here, it can be a namespaced class, and it will only pick last end of explode \\ string.
Should just use existing rector service Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer::hasPhpAttribute()
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there 👋
Here's a proposition to fix this old issue rectorphp/rector#9515
Here's a global explanation of the issue and proposed fix (if necessary):
PHP 8.1 added provisional return types to built-in interfaces (
ArrayAccess,Countable,Iterator,IteratorAggregateandStringable), triggering deprecation notices on implementations without matching return types.I created a new
AddReturnTypeWillChangeAttributeRectorrule that automatically detects affected methods, and adds#[\ReturnTypeWillChange]to suppress those notices.The rule is registered in the downgrade-php81 set so it runs automatically for anyone using ->withDowngradeSets(php81: true).
The rule is covered by unit tests, including fixtures for the positive cases (
ArrayAccess,Countable,Iterator,IteratorAggregateandStringable), and skip cases (method already has a return type, attribute already present).